Docs: Separate page for Branching and Tagging #6723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh-jahagirdar
commented
Feb 1, 2023
amogh-jahagirdar
commented
Feb 1, 2023
jackye1995
reviewed
Feb 1, 2023
jackye1995
reviewed
Feb 1, 2023
amogh-jahagirdar
commented
Feb 1, 2023
nastra
reviewed
Feb 2, 2023
Contributor
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
overall LGTM, just a few small things
amogh-jahagirdar
force-pushed
the
branching-tagging-docs
branch
2 times, most recently
from
50791ac to
3346435
Compare
amogh-jahagirdar
force-pushed
the
branching-tagging-docs
branch
2 times, most recently
from
e1a3651 to
84ff37a
Compare
jackye1995
reviewed
Mar 20, 2023
jackye1995
reviewed
Mar 20, 2023
jackye1995
reviewed
Mar 20, 2023
jackye1995
reviewed
Mar 20, 2023
jackye1995
reviewed
Mar 20, 2023
jackye1995
reviewed
Mar 20, 2023
amogh-jahagirdar
force-pushed
the
branching-tagging-docs
branch
4 times, most recently
from
8f5ae46 to
bc6fa21
Compare
jackye1995
reviewed
Mar 24, 2023
jackye1995
reviewed
Mar 24, 2023
jackye1995
reviewed
Mar 24, 2023
jackye1995
reviewed
Mar 24, 2023
jackye1995
reviewed
Mar 24, 2023
amogh-jahagirdar
force-pushed
the
branching-tagging-docs
branch
2 times, most recently
from
8910681 to
aaa3aee
Compare
amogh-jahagirdar
force-pushed
the
branching-tagging-docs
branch
2 times, most recently
from
4e4207b to
dcb8cb3
Compare
jackye1995
reviewed
Mar 27, 2023
jackye1995
reviewed
Mar 27, 2023
amogh-jahagirdar
force-pushed
the
branching-tagging-docs
branch
4 times, most recently
from
32fdbd6 to
6ecc6d1
Compare
hililiwei
reviewed
Apr 7, 2023
hililiwei
reviewed
Apr 7, 2023
jackye1995
reviewed
Apr 19, 2023
jackye1995
reviewed
Apr 19, 2023
jackye1995
reviewed
Apr 19, 2023
amogh-jahagirdar
force-pushed
the
branching-tagging-docs
branch
from
6ecc6d1 to
5e85dcb
Compare
jackye1995
reviewed
Apr 21, 2023
amogh-jahagirdar
force-pushed
the
branching-tagging-docs
branch
from
5e85dcb to
dcc3126
Compare
Contributor
|
@nastra @hililiwei @namrathamyske @holdenk do you have any further comments? |
hililiwei
reviewed
Apr 25, 2023
amogh-jahagirdar
force-pushed
the
branching-tagging-docs
branch
from
dcc3126 to
fec3aa8
Compare
Contributor
|
Thanks for the work Amogh, and thanks everyone for the review. Since this has been open for quite some time, I will go ahead to merge it, and we can address any additional feedback afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a separate page in Iceberg docs under the "Tables" section focused on branching and tagging.
cc: @jackye1995 @rdblue @namrathamyske @nastra @singhpk234 @rajarshisarkar @aokolnychyi @RussellSpitzer